Skip to content

Commit

Permalink
Add localized strings for contributions in About pane
Browse files Browse the repository at this point in the history
Additionally, an entry for filter list
contributors has been added.
  • Loading branch information
gorhill committed Apr 25, 2020
1 parent 9845e4d commit 01ab072
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 6 deletions.
16 changes: 12 additions & 4 deletions src/_locales/en/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -359,10 +359,6 @@
"message":"Block CSP reports",
"description": "background information: https://github.com/gorhill/uBlock/issues/3150"
},
"settingsStorageUsed":{
"message":"Storage used: {{value}} bytes",
"description":"Deprecated, will be removed"
},
"settingsLastRestorePrompt":{
"message":"Last restore:",
"description":"English: Last restore:"
Expand Down Expand Up @@ -831,6 +827,18 @@
"message":"Contributors",
"description":"English: Contributors"
},
"aboutSourceCode":{
"message":"Source code",
"description":"Link text to source code repo"
},
"aboutTranslations":{
"message":"Translations",
"description":"Link text to translations repo"
},
"aboutFilterLists":{
"message":"Filter lists",
"description":"Link text to uBO's own filter lists repo"
},
"aboutDependencies":{
"message":"External dependencies (GPLv3-compatible):",
"description":"Shown in the About pane"
Expand Down
5 changes: 3 additions & 2 deletions src/about.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@
<div class="li"><a href="https://github.com/gorhill/uBlock" data-i18n="aboutCode"></a></div>
<div class="li"><span data-i18n="aboutContributors"></span></div>
<div class="liul">
<div div class="li"><a href="https://github.com/gorhill/uBlock/graphs/contributors">GitHub</a></div>
<div div class="li"><a href="https://crowdin.net/project/ublock">Crowdin</a></div>
<div class="li"><a href="https://github.com/gorhill/uBlock/graphs/contributors" data-i18n="aboutSourceCode"></a></div>
<div div class="li"><a href="https://crowdin.net/project/ublock" data-i18n="aboutTranslations"></a></div>
<div div class="li"><a href="https://github.com/uBlockOrigin/uAssets/graphs/contributors" data-i18n="aboutFilterLists"></a></div>

This comment has been minimized.

Copy link
@jspenguin2017

jspenguin2017 Apr 25, 2020

Contributor

Why these two divs have empty attributes called div? Is it a typo?

This comment has been minimized.

Copy link
@gorhill

gorhill Apr 25, 2020

Author Owner

Oops, yes, typos.

</div>
<div class="li"><span data-i18n="aboutDependencies"></span></div>
<div class="liul">
Expand Down

0 comments on commit 01ab072

Please sign in to comment.