uBO 1.14.0 & 1.13.11rc2 causing severe lag, page loading time increased

[hapibukipa]

1.13.11rc2 & 1.14.0
Guessing the issue is this

#2925

Switched to a new filter storage & after migration uBo performance took a severe hit.

Created a new profile and started fresh,
Page take a lot longer to load upto 5x, opening 3-4tabs the loading of these pages take a very very long time.
if i open two tabs with bugzilla & cnn.com
typing in bugzilla is lagging and page scroll "janks"
At random if i open ublock dash board Firefox says a page might be slowing it down.

Have only easylist & easyprivacy as filters.
rest of the settings of uBo & Firefox 57 are defaults.

Reverting to previous version fixes all the above issues.

Windows 10 RS2 Firefox 57 x86 4gb ram 4 core AMD Cpu

[gorhill]

Please don't guess.

Use the Gecko profiler and profile the launching of uBO.

All worked fine here, and launch time have been markedly improved with indexedDB -- thus marking as unreproducable. Whoever feels like adding something here, do it with relevant information only, and profiling data for uBO launch time is what is relevant.

[hapibukipa]

okay didn't know about it,
so profiling it with loading a few tabs and attaching here.
And the guess was that uBo was the problem.

[gorhill]

Here is what it looks on my side -- that is the result of enabling/disabling uBO three times:

Keep in mind this is the result of three launches of uBO, so it's quite fast clearly -- this means roughly under 200ms per launch.

Now I have to ask: why didn't you rush (like you just did) to test this in the dev build yesterday when I asked for feedback?

[hapibukipa]

@gorhill

New to this

http://bit.ly/2wiIAWS

Started it as soon as Firefox started,
Then started loading pages,
The whole time pages were loading.
Doing one more .

Please listen first, yesterday it was not seen by me.
Also
It's not that uBo initializes fast or whatever the right term is,
It's that it is causing slow downs whether it's storage, or scripts or uBo other stuff.

[hapibukipa]

http://bit.ly/2wixEs9

Enabled uBo and opened 3 tabs,
look at the slowdowns.

[hapibukipa]

If you want can do one with Rc0 which works fine BTW
And this profiling idk so if you want me to do something to your liking just ask.

[gorhill]

uBO launch time looks fine to me, I see ~540 ms, which is expected. Keep in mind you are running uBO out-of-process:

In your second profiling results, uBO is doing even better, ~210 ms load time:

Note that I isolate uBO's CPU contribution by filtering using moz-, because webext extensions reside in moz-extension://. It does not seem you have other webext installed, so I am attributing all the CPU samples to uBO, and the stack trace matches this anyways.

I have no clue was is causing your slowdown in there, there are no debug symbols in your profiling data, I suggest you report to Firefox devs.

[crssi]

I can see the same symptoms and when FF is launched it is "frozen" for about 5 to 10 seconds.

Will try with a clean profile and report back.

[gorhill]

This is with 1.13.10, .i.e. using the webext storage only, in which I get ~1750 ms for three enable/disable, i.e. roughly 583 ms per launch:

So aside Firefox devs suggesting that indexedDB should be used for large chunks of data, the profiling of 1.13.10 confirms this.

Again, please just report to Firefox devs, I can't reproduce your issue, and if there is an issue on your side, this is outside uBO realm, I just followed the recommendations of Firefox devs, and the profiling I get confirm this was the right thing to do. Your issue need to be looked into by Firefox devs.

[hapibukipa]

@gorhill

no debug symbols in your profiling data

How do i do that?

Okay profiling with old uBo
see if you can see the difference?

The problem is mainly "Page loading slow downs"

Not the starting of uBo etc

As for Firefox dev "they are not always right"

[gorhill]

How do i do that?

I don't know, I have none either.

It's up to Firefox devs to accept your profiling data or not. I have seen a case on bugzilla where it seemed to me like the Activity Streamer was causing performance issue, but the Mozilla person didn't pick this and rather just pointed out that the symbols were missing.

[gorhill]

The problem is mainly "Page loading slow downs"
Not the starting of uBo etc

Ok, let me look again then. Just understand that the changes about indexedDB are completely uninvolved in page load -- the indexedDB is used strictly to save/load filter lists et al., nothing else.

[hapibukipa]

@gorhill

http://bit.ly/2wiLFGi

Same thing did as with RC2 but with RC0
with enabling uBo and loading the same 3 tabs
& they loaded & stopped profiling.

It didn't even with RC2

[hapibukipa]

@gorhill

understand that the changes about indexedDB are completely uninvolved in page load -- the indexedDB is used strictly to save/load filter lists et al., nothing else.

So did something else chage which could have caused this?

Using RC2 is nearly impossible .
Pages are loading way to slowly& CPU usage is very high.

[gomoku]

The same symptoms here (except that I'm not claiming that it is uBlock causing it, it might be a Firefox's bug, I just don't know) on FF 55.0.3 32bit + e10s enabled, as my uBlock Origin has recently autoupdated from 1.13.8 to 1.13.10, I've decided to switch from 1.13.10 to 1.13.11rc0, because as everybody know - 1.13.10 is broken due to a Firefox's bug, but I've switched back from 1.13.11rc0 to 1.13.8 right now, because I've noticed that on 1.13.11rc0 the performance of uBlock and the whole browser is very bad, everything is laggy, both FF UI & uBlock UI are lagging, the UI actions takes 2-3sec, for example: in uBlock switching between tabs or clicking "apply settings" button takes 2-3sec, also webpages loading slowly. After switched back to 1.13.8, everything is fast. Sorry for not giving some performance profiling data, because I don't know if I want to switch back to 1.13.11rc0 to test it, if I decide so, I'll add some profiling data. Also another issue is that some of filters were not working for example: @@||*.dcs.redcdn.pl^$domain=dcs.redcdn.pl|www.tvn24.pl was not working in 1.13.11rc0, even if the filter removed and added again, after switching back to 1.13.8 the filter works, btw also some static filters don't work on 1.13.8, but I'm currently waiting for a reply from my buddy, to confirm it, so if I decide to report the filter issues more detailed, I'll do it in a new separate thread.

[hapibukipa]

@gorhill

the comment above is similar to mine

the performance of uBlock and the whole browser is very bad, everything is laggy, both FF UI & uBlock UI are lagging, the UI actions takes 2-3sec, for example: in uBlock switching between tabs or clicking "apply settings" button takes 2-3sec, also webpages loading slowly.

Something is wrong here,
Trying a new profile again and profiling loading 3 tabs again, please compare rc0 results with rc2 in term of the above quote.

[gorhill]

Mostly what I see happening in your profile is reddit's own code hogging the CPU. uBO's code itself is below 4% in the content thread (where the pages are loaded). I see an overhead from webextensions javascript code from resource://gre/modules/Schemas.jsm.

So as said, report to Firefox devs if you think there are performance issues.

I will close this issue now because of the comments which adds no data to make the case there is an issue with uBO proper. So far, my profile and yours do not support this.

[gorhill]

Just be advised that I will be locking this thread if the added comments amount to nothing else than speculations -- i.e. no profiling data to support the case. I will appreciate also from now on that any profiling data comes with at least a succinct analysis of why you think it makes the case uBO proper is the issue.

I spent already quite a good amount of time on this, just to find out there is nothing wrong with uBO itself. I won't investigate issues outside uBO.

[hapibukipa]

http://bit.ly/2vFsAvi

Since I did the profiling when you wrote the above comment.
Please check it and see the page loading times etc, I don't know what to make out of it,
Glad this time i did with different websites
Also please do consider win10 & 32 bit firefox.

If you still feel that it's not uBo then no problem,
let the update push be complete, keep this thread open.

[crssi]

OK. FF 55.0.3, uBO 1.13.11rc2

Throw in 3rd party filters additional filters... see list at the end.
Open any of your desired web page.
Additionally open also about:profiles and click restart normally. When FF restarts click on a your desired web page tab.
In the previous version (non WE/hybrid) this worked instantly. Now FF chokes 5-10 seconds... also there are lags when browsing as reported in first post.
I guess indexDB doesn't like too many entries. And I guess I will have to lower the list count.

https://cybercrime-tracker.net/all.php
https://hosts-file.net/wrz.txt
https://hosts-file.net/psh.txt
https://hosts-file.net/pha.txt
https://hosts-file.net/hphosts-partial.txt
https://hosts-file.net/hjk.txt
https://hosts-file.net/hfs.txt
https://hosts-file.net/grm.txt
https://hosts-file.net/fsa.txt
https://hosts-file.net/exp.txt
https://hosts-file.net/emd.txt
https://malc0de.com/bl/IP_Blacklist.txt
https://openphish.com/feed.txt
https://raw.githubusercontent.com/quidsup/notrack/master/trackers.txt
https://filters.adtidy.org/extension/chromium/filters/14.txt
https://ssl.bblck.me/blacklists/ublock-origin.txt
https://filters.adtidy.org/extension/chromium/filters/2.txt
https://hexxiumcreations.github.io/threat-list/hexxiumthreatlist.txt
https://www.kiboke-studio.hr/i-dont-care-about-cookies/abp/
https://easylist-downloads.adblockplus.org/message_seen_remover_for_facebook.txt
https://raw.githubusercontent.com/piperun/iploggerfilter/master/filterlist
https://filters.adtidy.org/extension/chromium/filters/3.txt
https://filters.adtidy.org/extension/chromium/filters/4.txt
https://filters.adtidy.org/extension/chromium/filters/15.txt
https://raw.githubusercontent.com/metaphoricgiraffe/tracking-filters/master/trackingfilters.txt
https://raw.githubusercontent.com/byaka/ublock-antiskimming-list/master/build/data.txt
https://easylist-downloads.adblockplus.org/yt_annoyances_other.txt
https://easylist-downloads.adblockplus.org/yt_annoyances_suggestions.txt

[gorhill]

@hapibukipa http://bit.ly/2vFsAvi

Stop abusing the repo please, as said above, you could have found in one second that uBO has nothing to do with your issue. Top pic is your overall CPU usage, bottom pick is uBO's own CPU usage:

[gorhill]

I guess [...] I guess

@crssi This is not the place for pure speculations, there are places were pure speculations are welcomed and where people like to wallow in them. This repo is not one of these places.

As predicted, locking this thread.