Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Firefox] Use local image in Add-ons Manager #3196

Closed
ujc75573 opened this issue Nov 4, 2017 · 3 comments
Closed

[Firefox] Use local image in Add-ons Manager #3196

ujc75573 opened this issue Nov 4, 2017 · 3 comments

Comments

@ujc75573
Copy link

ujc75573 commented Nov 4, 2017

Hi, is it possible to use local icons instead of the ones from Mozilla?

https://addons.cdn.mozilla.net/user-media/addon_icons/607/607454-64.png

I noticed this when I browsed the Add-ons Manager and used Inspector. I noticed that only uBlock is making a 3rd party request to retrieve an image from Mozilla.

Sample

I think that in the previous versions (before the web extension), uBlock is able to use a local image.

  • OS/version: Windows 7
  • Browser/version: Firefox 56.0
  • uBlock Origin version: 1.14.17rc1

Hoping for your kind consideration, thanks.

@gorhill gorhill added the invalid label Nov 4, 2017
@gorhill
Copy link
Owner

gorhill commented Nov 4, 2017

uBO has nothing to do with how the about:addons page is rendered -- this is all under control of the browser.

@gorhill gorhill closed this as completed Nov 4, 2017
@gwarser
Copy link
Contributor

gwarser commented Nov 4, 2017

I think, this may be because UBO uses 64px icon (from where?). They require now 48 and 96px.
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/icons

Refined Github also uses 64px icon served from addons.cdn.mozilla.net

UBO-Scope have 64px icon packed in xpi, and this one is used.

@gorhill gorhill removed the invalid label Nov 4, 2017
@gorhill
Copy link
Owner

gorhill commented Nov 4, 2017

@gwarser Thanks for the hint, I will try 48px/96px to see if this makes a difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants