Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filters starting with * and followed by a uppercase letter are improperly parsed #3581

Closed
gorhill opened this issue Mar 7, 2018 · 0 comments
Closed

Filters starting with * and followed by a uppercase letter are improperly parsed #3581

gorhill opened this issue Mar 7, 2018 · 0 comments

Comments

@gorhill
Copy link
Owner

gorhill commented Mar 7, 2018

First reported on Reddit: https://www.reddit.com/r/uBlockOrigin/comments/81cxtm/question_about_wildcard/.

Quoting myself as to why this occurs:

The crux of the issue is whether the first letter is uppercase or not. The filter is improperly parsed if the first letter is uppercase. I forgot to use the i flag in a regex used to detect filters prefixed with a *.

It's highly unlikely that such filter exists in any of the filter lists. In any case, fix is trivial.
@gorhill gorhill closed this as completed in 081e5b4 Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gorhill