Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic filtering have no effect #873

Closed
gwarser opened this issue Oct 27, 2015 · 3 comments
Closed

Cosmetic filtering have no effect #873

gwarser opened this issue Oct 27, 2015 · 3 comments
Labels

Comments

@gwarser
Copy link
Contributor

gwarser commented Oct 27, 2015

On this page http://florydziak.blogspot.com/2015/10/starszy-brat.html ("popup" with article)
fl

For example "Fanboy’s Annoyance List" ##.share-controls, filters created by picker or manually.
Filters are visible in uBlock log. Sometimes they are applied, but very rarely. Mostly on first time, when loaded in background (last time happens when juggling with filter list and reloading from uBlock log).
I know, this page is broken: sometimes stops loading on "cogwheels" screen. Sometimes buttons in top left corner are missing (<, >, g+). Browser console reports problem with x-frame-options:

Security Error: Content at https://www.blogger.com/comment-iframe.g?blogID=8681818539802867443&postID=6053747354527061714 may not load data from http://florydziak.blogspot.com/2015/10/starszy-brat.html.
Load denied by X-Frame-Options: https://www.blogger.com/comment-iframe.g?blogID=8681818539802867443&postID=6053747354527061714 does not permit cross-origin framing. <unknown>

Should this affect uBlock?

I see this for some time on Fx 41 (42, 43) on Win7, Mint17, uBlock 1.3.2rc4 with EasyList+uBlock+uBlockPrivacy+florydziak.blogspot.com##.share-controls (and earlier uBlock versions with more filters)

@gorhill
Copy link
Owner

gorhill commented Oct 28, 2015

Looks like uBO's style tag is being removed by the site. Need to investigate more.

@gwarser
Copy link
Contributor Author

gwarser commented Oct 30, 2015

@gorhill
Copy link
Owner

gorhill commented Oct 30, 2015

Attaching the mutation observer to the html element fixes the issue.

Correction: the body element is not removed, rather all the style tags -- including the one installed by uBO before the DOM completely loads for specific or cached cosmetic filters -- are removed.

@gorhill gorhill changed the title [Firefox] cosmetic filtering have no effect Cosmetic filtering have no effect Oct 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants