Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subscribe links #951

Closed
szepeviktor opened this issue Nov 20, 2015 · 12 comments
Closed

Support subscribe links #951

szepeviktor opened this issue Nov 20, 2015 · 12 comments

Comments

@szepeviktor
Copy link
Contributor

Adblock Plus support:

Please consider supporting something like it.

@szepeviktor
Copy link
Contributor Author

abp: seems to be supported.

@5t3f4n
Copy link

5t3f4n commented Nov 20, 2015

This is already supported, but it seems you have to click a link form a site. Copying the URL and pasting in your URL bar does not seem to work. You can test for yourself here.

Example 1: clicking a link
Example 2: entering the URL

Edit: I was a bit late to the party.

@gwarser
Copy link
Contributor

gwarser commented Nov 20, 2015

Sorry, my browser hangs, and I accidentally removed my comment.
It seems this feature works only on pages with at least one abp: link (I cannot create one on github to test it here)
https://github.com/gorhill/uBlock/blob/master/src/js/subscriber.js#L56
about nonexistent subdomain:
ecd003f#diff-d0d30b0cde5061835204065d823f53c4R87

@szepeviktor
Copy link
Contributor Author

@5t3f4n Yes, that is a pseudo URL, only for links.

@szepeviktor
Copy link
Contributor Author

@gwarser My problem is the same: I use this pseudo URL ( https://subscribe.adblockplus.org ) because GitHub does not allow the abp: scheme.

@szepeviktor
Copy link
Contributor Author

It would be nice to support this or another pseudo URL.

@szepeviktor
Copy link
Contributor Author

@gorhill Thank you very much.

@happysurf
Copy link

No more works for me because is open only the .txt page instead the subscription dialog window.
Firefox 43beta7 + UBO 1.3.7b8.

@gorhill
Copy link
Owner

gorhill commented Dec 1, 2015

@happysurf what link exactly are you trying to click?

@happysurf
Copy link

Any "Subscribe" links on https://github.com/gorhill/uBlock/wiki/Filter-lists-from-around-the-web but also on Prebake page button, or on the page http://www.kiboke-studio.hr/i-dont-care-about-cookies/ links like:
http://www.kiboke-studio.hr/i-dont-care-about-cookies/abp/
abp:subscribe?location=http://www.kiboke-studio.hr/i-dont-care-about-cookies/
Still doesn't work with UBO 1.3.7b10.

@gorhill
Copy link
Owner

gorhill commented Dec 2, 2015

Any "Subscribe" links on https://github.com/gorhill/uBlock/wiki/Filter-lists-from-around-the-web

Works fine from here. Are you clicking the subscribe link? The link above the subscribe link is to go to the list's site so that one can look at the list before installing it.

@happysurf
Copy link

I know, in any case I tried Firefox 43 beta + uBO 1.3.7b10 in a clean profile and works.
Then I discover the culprit, the Clean LInks extension change the link on the fly.
Thank you for support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants