support https and pluggable dialers #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me but I'm not familiar with the code base/design decisions very well. @davecheney ? |
|
How would I use the result of this patch to setup an http(s) client with a specific tls.Config provided? |
|
oh whoa old pull request. i'm not sure i even want to merge this anymore |
|
Meaning there's some other way of using gorilla/http over ssl/tls? |
|
oh, i don't actually know the answer to that. we stopped using gorilla/http, but i definitely have some complaints with this patchset as-is. i was kind of a go-newbie |
|
go-newbie, exactly, that's me now... can I ask why you walked away from gorilla/http? what you changed it for? |
|
we're just using the standard library net/http |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18 and #8
i'm unhappy that Dial matches the signature of net.Dial. :(
accepting network/address to the Dialer interface that does caching seems like the wrong abstraction layer here though, since we want to pool connections based on if they're ssl or not.
so, possible options: rename Dial to something else, Connect maybe? or maybe make some Scheme and Host types that are just strings?
i dunno.