pattern aliases

[HiveTraum]

✋Reopened #598 because i noticed that the project came to life

This feature introduces ability to register aliases for some often used regular expressions.

For example path as this:
/{category:[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-4[a-fA-F0-9]{3}-[8|9|aA|bB][a-fA-F0-9]{3}-[a-fA-F0-9]{12}}/{product:[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-4[a-fA-F0-9]{3}-[8|9|aA|bB][a-fA-F0-9]{3}-[a-fA-F0-9]{12}}
can be transformed into this
/{category:uuid}/{product:uuid}

You need just use register it

router := NewRouter()
router.RegisterPattern("uuid", "[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-4[a-fA-F0-9]{3}-[8|9|aA|bB][a-fA-F0-9]{3}-[a-fA-F0-9]{12}")
router.Path("/{category:uuid}")
router.Path("/{product:uuid}")
router.Path("/{order:uuid}")
router.Path("/{user:uuid}")

1. New method RegisterPattern on Route struct
2. New method RegisterPattern on Router struct

[amustaque97]

We should move this test case in the file: example_route_test.go

[HiveTraum]

modev example

[amustaque97]

Can we add comments here?

[HiveTraum]

Added comments

[amustaque97]

Same, can we add comment here as well?

[HiveTraum]

Added comments

[amustaque97]

Can we add negative test case where shouldMatch is false because of mismatch.

[HiveTraum]

Added negative test case

[amustaque97]

Both the test cases look similar to me.

1. First one:

{
	title:        "Path route with regexp alias patterns",
	route:        new(Route).RegisterPattern("digits", "[0-9]+").Path("/{id:digits}"),
	request:      newRequest("GET", "http://localhost/1"),
	vars:         map[string]string{"id": "1"},
	host:         "",
	path:         "/1",
	pathTemplate: `/{id:digits}`,
	shouldMatch:  true,
}

2. Second:

{
	title:        "Path route with regexp alias patterns passed through router",
	route:        NewRouter().RegisterPattern("digits", "[0-9]+").Path("/{id:digits}"),
	request:      newRequest("GET", "http://localhost/1"),
	vars:         map[string]string{"id": "1"},
	host:         "",
	path:         "/1",
	pathTemplate: `/{id:digits}`,
	shouldMatch:  true,
}

We should add at least one negative test case. What do you think?

[HiveTraum]

Yeah, seems like this tests was very similar, deleted second test and added negative test case

[amustaque97]

Thank you @HiveTraum for bringing this up again. I have added a couple of comments. I need some more time to review it completely. In the meantime, I Would love to hear from you.

[HiveTraum]

@amustaque97 Done 👍

[amustaque97]

Thank you for working on comments. Changes looks good to me.

[amustaque97]

@elithrar , I reviewed the PR and changes looks good to me and ready to ship 🚀

I would request you to please take a final look at this and if all good. Can we merge it?

[HiveTraum]

Yes, it's ready to merge