Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add method to acknowledge expected/temporary read errors #912

Closed
wants to merge 1 commit into from
Closed

Conversation

dpeckett
Copy link

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Go Version Update
  • Dependency Update

Description

Add a method for explicitly acknowledging read errors are temporary. This is useful when read timeouts are expected, such as in a non blocking loop with context cancellation etc.

Related Tickets & Documents

Added/updated tests?

  • Yes
  • No, and this is why: negligible code changes
  • I need help with writing tests

Run verifications and test

  • make verify is passing
  • make test is passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: repeated read on failed websocket connection
1 participant