Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed andand dependency #13

Closed
wants to merge 1 commit into from
Closed

Conversation

cjmarkham
Copy link

The andand gem was causing us issues at compile [1] time so I removed the dependency while keeping functionality.

[1]

/rof/cache/bundler/ruby/2.2.0/gems/andand-1.3.3/lib/andand.rb:66: [BUG] Stack consistency error (sp: 193, bp: 192)
ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-linux]

@gorn
Copy link
Owner

gorn commented Oct 28, 2015

I am not persuaded that removing andand is not bad for readibility and effectivness. Also your error looks supicious there is 2.2.0 as well as 2.2.3 ruby version mentioned at the same line. Are you sure that you are not mixing up two verions of ruby? ... and do not get me wrong, I am really interested in your change, because it can point to some wierd mistakes in the code under some verions of ruby, which I want to avoid. Can you post what steps you followed while trying to compile the code (I am not sure I understand what it means in terms of ruby).

Inspired by your error I have added some verions of ruby to automatic testing, but everything seems to work fine

@cjmarkham
Copy link
Author

I think the issue is a conflict with andand and Nokogiri since andand uses ruby-libxml and nokogiri uses C libxml2 system library natively.

Also, Ruby uses major/minor versioning. So any 2.2.x ruby gems will go in the 2.2.0 folder.

@gorn
Copy link
Owner

gorn commented Oct 28, 2015

Andand uses ruby-libxml? Isn't it mixed up directly to Object? I see no reason why it should do so ... there should be another mistake.

PS: You are right with folders, my bad.

@cjmarkham
Copy link
Author

Ignore that comment about andand using ruby-libxml it was wrong. I will do some debugging tomorrow in an isolated environment to determine why andand was causing issues with our stack. Removing it did solve the problem though. I will let you know what I find.

@gorn
Copy link
Owner

gorn commented Nov 6, 2015

Ok, I am closing this pull request for now, but let me know if you find something.

@gorn gorn closed this Nov 6, 2015
@gorn gorn removed the in progress label Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants