Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage for isSharingStockFinished #10

Merged
merged 1 commit into from
Nov 15, 2017
Merged

coverage for isSharingStockFinished #10

merged 1 commit into from
Nov 15, 2017

Conversation

adasq
Copy link
Contributor

@adasq adasq commented Nov 14, 2017

#7

@adasq adasq requested a review from alan-null November 14, 2017 08:59
alan-null
alan-null approved these changes Nov 15, 2017
View reviewed changes
Copy link
Contributor

@alan-null alan-null left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now we validate a single state, but case when game has started and there are less than 24 cards should return true.
Do you think that it is possible to execute isSharingStockFinished after game started?

@adasq
Copy link
Contributor Author

adasq commented Nov 15, 2017

when users will have less than 24 cards that means we are no longer in sharing mode

@adasq adasq merged commit 8fb240a into master Nov 15, 2017
@adasq adasq deleted the is-sharing-stock-finished-coverage branch December 5, 2017 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-null alan-null alan-null approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adasq @alan-null