Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow active_support upto 8 #7

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ankithads
Copy link

why?
We need this to resolve the dependency to bump Payments service to rails 7.1 bump

@@ -27,7 +27,7 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ["lib"]

spec.add_runtime_dependency "activesupport", ">= 3.0.0", "< 7.1"
spec.add_runtime_dependency "activesupport", ">= 3.0.0", "< 8"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would preferably be < 7.2.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@ankithads ankithads force-pushed the support-for-rails-7.1-bump branch from 648c9cc to 7dd3ffa Compare May 1, 2024 10:24
why?
We need this to resolve the raisl 7.1 dependency
@ankithads ankithads force-pushed the support-for-rails-7.1-bump branch from 7dd3ffa to a7ff1ae Compare May 2, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants