-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump @gmod dependencies and generic-filehandle #849
Conversation
seem to be issue with bigwig files .. |
Ok I updated the
instead of just relying on a global. This is easier for bundlers to resolve, and something that I implemented a while ago in |
Thanks for letting me know. I might not be able to find time this week but probably possible next week. |
@@ -86,7 +86,7 @@ function BigWigDataFetcher(HGC: import('@higlass/types').HGC, dataConfig: BigWig | |||
this.dataPromises.push(this.loadBBI(dataConfig)); | |||
} | |||
|
|||
loadBBI(dataConfig: { url: string }) { | |||
async loadBBI(dataConfig: { url: string }) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this change was needed by some recent changes in BBI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not exactly. This function returns either a promise or null
, and we push the results to dataPromises
. Previously the return type was Promise<void> | null
. The async makes it always return a Promise.
async loadBBI(dataConfig: { url: string }) {
if (dataConfig.url) {
this.bwFile = new BigWig({
filehandle: new RemoteFile(dataConfig.url)
});
return this.bwFile.getHeader().then((h: BigWigHeader) => {
this.bwFileHeader = h;
});
} else {
console.error('Please enter a "url" field to the data config');
return null;
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see – Good to know that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change -- tested locally with demo examples and works well
@manzt Now there is a conflict in |
yah we can just copy the lock file over from master or relock.
|
ok, I rebased the changes @sehilyi |
Thanks! I will go ahead and merge this. |
* chore: bump @GMOD dependencies and generic-filehandle * fix: broken bbi
Closes #807
Change List
@gmod/*
packagesgeneric-filehandle
optimizeDeps.esbuildOptions.inject
to injectBuffer
polyfill globally for all dependencies.Checklist