Issue 312: http proxy support #589
Conversation
|
Eyeball check on the changes look good. Couple of things are needed before this can be merged:
|
…e_312 Conflicts: integration-tests/test.sh
|
Updated docs. I managed to get all the containers working except for arch. Otherwise should be good to go. |
|
Hi guys, I would really love to see this feature. Any reason it was not merged? |
|
@aelsabbahy Could you support here? Maybe you can temporarly grant write access to @OperationalDev so he can merge? Can I do anything to support (I have basic knowlege in go)? |
Yes, the problem with this PR is that it disables the Archlinux integration tests (see makefile changes). I've been prioritizing reviewing and merging other PRs that have a full set of passing tests. With this PR, one of two things need to happen before it's merged, either: B) I eventually get around to trying to fix/update the tests for this PR myself. I don't have a timeline on that since I have a lot of other PRs I'm working on at the moment. "A" Gets this PR merged sooner, I think "B" will eventually happen.. but no set timeline. |
@damzog I added tests for the proxy functionality to each of the distros that make up the testing. I did not want to use an external proxy and add dependencies, so I decided to add a proxy (I opted for tinyproxy) to each of the docker images. Unfortunately the docker files are quite old and in some cases no longer valid (Arch/Wheeezy). Also in the case of Precise being end of life, this had it's own challenges with getting tinyproxy to work. I've did manage to get the Precise/Wheezy images to work, but the Arch image isn't working. I could disable the proxy tests for Arch, but that just felt like the wrong solution here. Feel free to take a look. P.S. with Windows/Darwin being added, these would need some sort of proxy as well. |
https://travis-ci.org/github/aelsabbahy/goss/jobs/729495936#L5553 Seems the precise test is what's broken. The @OperationalDev When you get a chance, take a look at these changes. I think they're a step in the right direction.
https://github.com/OperationalDev/goss/compare/issue_312...aelsabbahy:issue_312_fixes?expand=1 Once tinyproxy is working correctly in trusty this PR is good to go. Side/future note: I might refactor the tests moving forward to only test package/service on each OS type and only do the full integration test on one OS. |
|
One thing I forgot to mention precise works great locally on my laptop (Fedora), but is acting up in travis.. not sure why yet.. the last commit I added a debug by doing Related note, created a new ticket #649 to move off of travis-ci. Each build is taking 45m-1hr. That combined with the lack of ability to reproduce this locally is really sucking. Sorry for the delay in reviewing this.. finally was able to get around to it. |
|
Thank you for your contribution. I made some updates to your PR to allow the tests to pass. This should be in the next goss release. Awesome feature, appreciate you taking the time to work on this. |
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
Added proxy support as per #312 . Supports proxy environment variables and setting a proxy per resource. Setting proxy on resource takes precedence over proxy environment variables.
Testing adds tinyproxy and tests connecting to a remote URL through it.
Note: I've disabled arch and wheezy images from tests as the actual containers don't seem to be working. If the images are fixed tinyproxy is available for both.