Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added DGOSS_TEMP_DIR environment variable. #684

Merged
merged 2 commits into from
Sep 16, 2023

Conversation

ksaito1125
Copy link
Contributor

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

Description of change

Location of the temporary directory used by dgoss.

@ksaito1125
Copy link
Contributor Author

#675

@stale
Copy link

stale bot commented May 15, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used by https://probot.github.io/apps/stale/ label May 15, 2021
@stale stale bot closed this May 23, 2021
@aelsabbahy aelsabbahy reopened this Sep 14, 2022
@aelsabbahy aelsabbahy removed the stale Used by https://probot.github.io/apps/stale/ label Sep 14, 2022
@aelsabbahy
Copy link
Member

aelsabbahy commented Sep 14, 2022

Hello, thank you for taking the time to contribute this. I've removed the stale and I'm going through the old PRs that were impacted by it.

Can you provide a little bit of context on the use-case of this. I understand what it does on a technical level, just trying to better understand when it's needed by the user?

Is it related to this? #329

@aelsabbahy aelsabbahy self-requested a review as a code owner September 16, 2023 19:05
@aelsabbahy
Copy link
Member

I'm merging this as it seems like a good feature to have, and seems to be a solution for #329

Thank you for the great contribution, apologies for the extremely long delay in merging this.

@aelsabbahy aelsabbahy merged commit deeda38 into goss-org:master Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants