add more labels to prometheus output #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a 'resource_id' label to each test-specific metric if the 'verbose' format option was enabled. Since we only have access to format options in the 'Output' method, we are creating metrics during the first run of that method. Metrics can only be registered once for any given set of labels, so we create a custom registry and use the existence of that as a check whether we need to create/register metrics. This has the added benefit of simplifying the test a tiny bit, and it exposes even less metrics on the /health endpoint. fixes goss-org#862 Signed-off-by: Sebastian Hoß <seb@xn--ho-hia.de>
Signed-off-by: Sebastian Hoß <seb@xn--ho-hia.de>
petemounce
reviewed
Jan 13, 2024
There was a problem hiding this comment.
This LGTM; thanks. I'll await @aelsabbahy for approve.
I'll take care of adding documentation when #856 merges; I don't want to cause @noirbizarre a conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
This adds a
resource_idlabel to each test-specific metric if theverboseformat option was enabled. This assumes that the combination of resource ID and resource type is unique.Since we only have access to format options in the
Outputmethod, we are creating metrics during the first run of that method.Metrics can only be registered once for any given set of labels, so we create a custom registry and use the existence of that as a check whether we need to create/register metrics. This has the added benefit of simplifying the test a tiny bit, and it exposes even less metrics on the /healthz endpoint.
fixes #862
Pinging @petemounce @aelsabbahy