Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable deprecated codeclimate plugin golint #927

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

dklimpel
Copy link
Contributor

@dklimpel dklimpel commented Jun 8, 2024

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

Description of change

I have not seen an alternative for this plugin.

Reported error/line:

func mergeType[V any](m map[string]V, t, k string, v V) {

@dklimpel dklimpel requested a review from aelsabbahy as a code owner June 8, 2024 16:28
@aelsabbahy
Copy link
Member

Same question as other PR, does code climate offer any additional value at this point?

I feel it was added many years back and then ignored 😅

@aelsabbahy aelsabbahy merged commit 2be65b4 into goss-org:master Jun 16, 2024
2 checks passed
@dklimpel dklimpel deleted the codeclimate_golint branch June 16, 2024 17:02
@dklimpel
Copy link
Contributor Author

I feel it was added many years back and then ignored

If you do not used this, it can be removed in feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants