Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(botapi): fix schema, implement more methods #50

Merged
merged 19 commits into from
Dec 30, 2021

Conversation

tdakkota
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #50 (6fcdc53) into main (8e53c80) will decrease coverage by 0.46%.
The diff coverage is 21.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   33.10%   32.63%   -0.47%     
==========================================
  Files          34       36       +2     
  Lines        2462     2874     +412     
==========================================
+ Hits          815      938     +123     
- Misses       1616     1887     +271     
- Partials       31       49      +18     
Impacted Files Coverage Δ
botdoc/oas.go 0.00% <0.00%> (ø)
botdoc/opts.go 100.00% <ø> (ø)
internal/botapi/errors.go 22.22% <ø> (+20.38%) ⬆️
internal/botapi/errors_map.go 0.00% <0.00%> (ø)
internal/botapi/file_id.go 15.15% <0.00%> (+15.15%) ⬆️
internal/botapi/optional.go 61.11% <0.00%> (+11.11%) ⬆️
internal/botapi/rewrite.go 0.00% <0.00%> (ø)
internal/botapi/peers.go 38.75% <10.00%> (-2.04%) ⬇️
internal/botapi/send.go 32.43% <22.30%> (-3.74%) ⬇️
internal/botapi/chat.go 30.92% <23.89%> (-29.95%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e53c80...6fcdc53. Read the comment docs.

@tdakkota tdakkota mentioned this pull request Dec 29, 2021
88 tasks
@tdakkota tdakkota marked this pull request as ready for review December 29, 2021 14:31
@ernado ernado merged commit 7eb4122 into gotd:main Dec 30, 2021
@tdakkota tdakkota deleted the fix/handle-on-success-a branch December 30, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants