Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable connection options #115

Closed
own2pwn opened this issue Jan 9, 2021 · 2 comments
Closed

Configurable connection options #115

own2pwn opened this issue Jan 9, 2021 · 2 comments

Comments

@own2pwn
Copy link

own2pwn commented Jan 9, 2021

Hi, is there any reason these options aren't configurable?

td/telegram/conn.go

Lines 133 to 136 in b02db4f

SystemVersion: notAvailable,
DeviceModel: notAvailable,
AppVersion: notAvailable,
LangPack: "",

@ernado
Copy link
Member

ernado commented Jan 9, 2021

Hi, there is TODO:

td/telegram/conn.go

Lines 126 to 127 in b02db4f

// TODO(ernado): Make versions configurable.
const notAvailable = "n/a"

So no reason, just WIP

@ernado
Copy link
Member

ernado commented Jan 10, 2021

Done in #115

@ernado ernado closed this as completed Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ernado @own2pwn