fix(faketls): fix encoding SNI in faketls ClientHello #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for contribution! |
The offset calculation used in the stack code in the ClientHello creation function was incorrect, resulting in the SNI field not being correctly encoded and therefore not being able to connect to faketls mtproto proxies. Added parenthesis to fix the math. Signed-off-by: Mark Pashmfouroush <mark@markpash.me>
markpash
force-pushed
the
pr/markpash/faketls-bug
branch
from
1b1dd7b
to
736dd57
Compare
Hey no problem. I've updated the test. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1400 +/- ##
==========================================
+ Coverage 70.99% 71.10% +0.10%
==========================================
Files 442 442
Lines 17722 17723 +1
==========================================
+ Hits 12582 12602 +20
+ Misses 4203 4191 -12
+ Partials 937 930 -7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I found a really annoying bug that prevented me from being able to use faketls based mtproto proxies.
It took a couple of days to figure out why, but I finally found the problem. Luckily it's a quick fix.
Just FYI, the telegram android and desktop codebases have updated their faketls implementation and I was wondering if you'd be interested in me contributing a follow-up PR with those improvements.