Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(message): do not copy Builder #619

Merged
merged 1 commit into from
Dec 12, 2021

Conversation

tdakkota
Copy link
Member

No description provided.

@tdakkota tdakkota force-pushed the fix/do-not-copy-sender-builder branch from 5d00c50 to 70f65c2 Compare December 12, 2021 11:19
@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #619 (70f65c2) into main (9dfdf37) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
+ Coverage   69.27%   69.39%   +0.11%     
==========================================
  Files         400      400              
  Lines       18697    18690       -7     
==========================================
+ Hits        12953    12969      +16     
+ Misses       4906     4876      -30     
- Partials      838      845       +7     
Impacted Files Coverage Δ
telegram/message/builder.go 80.00% <100.00%> (-3.34%) ⬇️
tgtest/send.go 54.05% <0.00%> (-5.41%) ⬇️
tgtest/loop.go 65.00% <0.00%> (-5.00%) ⬇️
internal/proto/codec/intermediate.go 95.08% <0.00%> (-4.92%) ⬇️
tgtest/server.go 85.45% <0.00%> (-3.64%) ⬇️
internal/mtproto/conn.go 92.22% <0.00%> (-3.34%) ⬇️
tgtest/handle.go 40.19% <0.00%> (ø)
telegram/updates/internal/e2e/storage_mem.go 59.84% <0.00%> (+6.06%) ⬆️
internal/rpc/engine.go 84.18% <0.00%> (+9.60%) ⬆️
telegram/updates/state_apply.go 36.71% <0.00%> (+11.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dfdf37...70f65c2. Read the comment docs.

@ernado ernado merged commit 973adfb into gotd:main Dec 12, 2021
@tdakkota tdakkota deleted the fix/do-not-copy-sender-builder branch December 12, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants