Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(updates): sort updates before applying #675

Merged
merged 1 commit into from
Jan 23, 2022

Conversation

tdakkota
Copy link
Member

Updates #671

@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #675 (a176c94) into main (d4ce999) will increase coverage by 0.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
+ Coverage   68.86%   69.32%   +0.45%     
==========================================
  Files         425      426       +1     
  Lines       20355    20413      +58     
==========================================
+ Hits        14018    14151     +133     
+ Misses       5433     5352      -81     
- Partials      904      910       +6     
Impacted Files Coverage Δ
telegram/updates/sort_pts.go 100.00% <100.00%> (ø)
telegram/updates/state_apply.go 37.20% <100.00%> (+12.20%) ⬆️
telegram/updates/state.go 51.28% <0.00%> (+2.56%) ⬆️
telegram/updates/internal/e2e/storage_mem.go 59.84% <0.00%> (+6.06%) ⬆️
telegram/updates/internal/e2e/server.go 71.53% <0.00%> (+6.15%) ⬆️
telegram/updates/state_channel.go 52.83% <0.00%> (+7.07%) ⬆️
telegram/updates/classifier.go 32.87% <0.00%> (+10.95%) ⬆️
telegram/updates/update.go 71.42% <0.00%> (+61.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4ce999...a176c94. Read the comment docs.

Copy link
Member

@shadowspore shadowspore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tdakkota tdakkota marked this pull request as ready for review January 23, 2022 13:02
@tdakkota tdakkota merged commit f736044 into gotd:main Jan 23, 2022
@tdakkota tdakkota deleted the fix/sort-updates branch January 23, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants