Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector response decoding #8

Merged
merged 8 commits into from
Dec 11, 2020
Merged

Vector response decoding #8

merged 8 commits into from
Dec 11, 2020

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Dec 7, 2020

Fix #9

@coveralls
Copy link

coveralls commented Dec 7, 2020

Pull Request Test Coverage Report for Build 412474114

  • 88 of 140 (62.86%) changed or added relevant lines in 6 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.7%) to 32.162%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/gen/example/tl_registry_gen.go 0 1 0.0%
internal/gen/make_structures.go 16 19 84.21%
internal/gen/generic.go 41 45 91.11%
internal/gen/write_source.go 10 15 66.67%
internal/gen/example/tl_int_vector_gen.go 17 25 68.0%
internal/gen/example/tl_echo_vector_gen.go 4 35 11.43%
Files with Coverage Reduction New Missed Lines %
internal/gen/make_structures.go 2 91.26%
internal/gen/write_source.go 4 77.59%
Totals Coverage Status
Change from base Build 407681969: 0.7%
Covered Lines: 1620
Relevant Lines: 5037

💛 - Coveralls

@ernado ernado merged commit e4381ce into gotd:main Dec 11, 2020
@ernado
Copy link
Member

ernado commented Dec 11, 2020

Great, thank you!

@tdakkota tdakkota deleted the feature/vector-decoding branch May 29, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client: vector as rpc result
3 participants