Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting #4

Closed
lmichaelis opened this issue Jul 5, 2022 · 0 comments
Closed

Improve error reporting #4

lmichaelis opened this issue Jul 5, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@lmichaelis
Copy link
Member

At the moment, phoenix only reports some failures using custom exception classes. Ideally, any failure which needs to be reported to the user should be wrapped in a custom exception class.

There is also a discussion to be had about using exceptions at all. It might be better to report failures using std::optional or a custom std::expected structure than throwing exceptions since some codebases don't allow exceptions at all.

Since this is a parser library, failure can occur more often than usual thus performance is also a point to keep in mind when using exceptions to report parsing failures.

@lmichaelis lmichaelis added the enhancement New feature or request label Jul 5, 2022
@lmichaelis lmichaelis self-assigned this Jul 10, 2022
@lmichaelis lmichaelis added this to the v0.1.0 milestone Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant