Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle architecture #68

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

david4r4
Copy link
Contributor

@david4r4 david4r4 commented Jan 27, 2024

Closes #76

@david4r4 david4r4 marked this pull request as draft January 27, 2024 09:21
@david4r4 david4r4 marked this pull request as ready for review January 27, 2024 10:08
@clebert
Copy link

clebert commented Feb 26, 2024

When using setup-zig on macOS ARM runners, it currently downloads the x64 (Intel) version of Zig by default. I believe the changes proposed in this PR should resolve the issue by ensuring the ARM version of Zig is downloaded instead.

@david4r4
Copy link
Contributor Author

That is the reasoning of the change, since currently the action is unable to pick the right binary due to it being hardcoded.

Copy link
Owner

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Sorry for the wait :)

@goto-bus-stop goto-bus-stop merged commit ef1fbe2 into goto-bus-stop:default Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support macos-aarch64
3 participants