Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow creation of asset with owner identified by UUID #6

Merged
merged 1 commit into from
Mar 24, 2023
Merged

fix: allow creation of asset with owner identified by UUID #6

merged 1 commit into from
Mar 24, 2023

Conversation

sudo-suhas
Copy link

  • Fix create asset failure with owner(s) identified by UUID by fetching the Compass native user ID for the given UUID. Create the user if no user exists for the given UUID.
  • Refactor SQL for inserting owners to use squirrel SQL builder.

Closes #5

@sudo-suhas
fix: allow creation of asset with owner identified by UUID
2d0b77b 
- Fix create asset failure with owner(s) identified by UUID by fetching
  the Compass native user ID for the given UUID. Create the user if no
  user exists for the given UUID.
- Refactor SQL for inserting owners to use squirrel SQL builder.
@sudo-suhas sudo-suhas requested a review from haveiss March 23, 2023 11:31
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4500080027

  • 23 of 28 (82.14%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 86.149%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/store/postgres/asset_repository.go 23 28 82.14%
Totals Coverage Status
Change from base Build 4424920180: 0.007%
Covered Lines: 5013
Relevant Lines: 5819
💛 - Coveralls

@sudo-suhas sudo-suhas merged commit f64e1f3 into main Mar 24, 2023
@sudo-suhas sudo-suhas deleted the create-asset-with-owner-uuid branch March 24, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haveiss haveiss haveiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating asset with uuid gives internal server error
3 participants
@sudo-suhas @coveralls @haveiss