Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: offset reset history #42

Merged
merged 3 commits into from
Jul 17, 2023
Merged

feat: offset reset history #42

merged 3 commits into from
Jul 17, 2023

Conversation

ishanarya0
Copy link
Member

  • when reset action is triggered, entropy will save the offset reset value in env variables

@ishanarya0
feat: offset reset history
805f6ce 
- when reset action is triggered, entropy will save the offset reset value in env variables'
@ishanarya0
test: fix reset test
9704a84
@ishanarya0
fix: store offset reset value
939bdf5 
- SOURCE_KAFKA_CONSUMER_CONFIG_AUTO_OFFSET_RESET is not to be used to store resetoffset value since it is used by firehose to auto-offset-reset
- rather use a new field for this
@mabdh mabdh self-requested a review July 17, 2023 04:16
@ishanarya0 ishanarya0 merged commit 57a30e8 into main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spy16 spy16 spy16 left review comments

@mabdh mabdh mabdh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ishanarya0 @mabdh @spy16