Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor subscriptions receivers #62

Merged
merged 1 commit into from
May 20, 2024
Merged

feat: refactor subscriptions receivers #62

merged 1 commit into from
May 20, 2024

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented May 2, 2024 •
edited
Loading

  • Add subscription evaluation v2 as an alternative
  • Make the evaluation v2 approach as a toggle

@mabdh mabdh force-pushed the refactor-subscriptions-receivers branch from c79b84f to 9f4397f Compare May 4, 2024 14:44
@mabdh mabdh force-pushed the refactor-subscriptions-receivers branch 3 times, most recently from 40c30bb to a9f7493 Compare May 5, 2024 23:21
@mabdh mabdh marked this pull request as ready for review May 5, 2024 23:48
@mabdh mabdh force-pushed the refactor-subscriptions-receivers branch 2 times, most recently from f403096 to c4df1ea Compare May 6, 2024 07:54
github-advanced-security[bot]
github-advanced-security bot found potential problems May 6, 2024
View reviewed changes
internal/store/postgres/subscription.go Dismissed Show dismissed Hide dismissed
@mabdh mabdh force-pushed the refactor-subscriptions-receivers branch from c4df1ea to a3c6caf Compare May 6, 2024 08:15
@mabdh mabdh force-pushed the refactor-subscriptions-receivers branch 8 times, most recently from 4c91517 to e7dd7f5 Compare May 17, 2024 14:08
@mabdh mabdh force-pushed the refactor-subscriptions-receivers branch from e7dd7f5 to e2dd1dc Compare May 20, 2024 05:04
@mabdh mabdh merged commit cb928ec into main May 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manishdangi98 manishdangi98 Awaiting requested review from manishdangi98

@ishanarya0 ishanarya0 Awaiting requested review from ishanarya0

@FemiNoviaLina FemiNoviaLina Awaiting requested review from FemiNoviaLina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mabdh