Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Libraries not sorted for restricted user #140

Closed
sonostrass opened this issue Apr 12, 2020 · 3 comments
Closed

[Bug] Libraries not sorted for restricted user #140

sonostrass opened this issue Apr 12, 2020 · 3 comments
Labels
bug Something isn't working released

Comments

@sonostrass
Copy link

Komga environment

  • OS: W10 & IOS 13.3.1
  • Komga version: komga-0.26.2.jar
  • Java version: 1.8.0_241

I have a problem in the web interface

  • Browser: Firefox 75.0 (64 bits), Chrome 80.0.3987.163 (Build officiel) (64 bits), Safari for IOS 13.3

Describe the bug

Restricted users have their librairies list displayed in a random order

Steps to reproduce

  1. Create multiple librairies (I did one for each first letter)
  2. Create user with restricted acces to several librairies
  3. log off and reconnect with this user

Expected behavior

I suppose librairies should always being displayed in alphabetical order.
(and I guess a limited enhancement to modify an sort libraires would be great too)

Actual behavior

Librairies appear in random orders

Thanks for your hard work!
@sonostrass sonostrass changed the title [Bug] Library not sorted for limited user [Bug] Library not sorted for restricted user Apr 12, 2020
@sonostrass sonostrass changed the title [Bug] Library not sorted for restricted user Library not sorted for restricted user Apr 12, 2020
@sonostrass sonostrass changed the title Library not sorted for restricted user Libraries not sorted for restricted user Apr 12, 2020
@sonostrass sonostrass changed the title Libraries not sorted for restricted user [Bug] Libraries not sorted for restricted user Apr 12, 2020
@gotson
Copy link
Owner

gotson commented Apr 12, 2020 •
edited
Loading

Libraries are never sorted, whatever the user type.

For admin they appear in the order they were created.
For non-restricted users they are sorted by name.
For restricted users it might appear in the order in which you ticked the boxes to grant access.

I guess adding a sort by alphabetical order wouldn't hurt.

@sonostrass
Copy link
Author

Seems good to me.

Nice work, by the way.

@gotson gotson added the bug Something isn't working label Apr 13, 2020
@gotson gotson closed this as completed in 1d58322 Apr 13, 2020
gotson pushed a commit that referenced this issue Apr 13, 2020
@semantic-release-bot
chore(release): 0.27.0 [skip ci]
450ae90 
# [0.27.0](v0.26.3...v0.27.0) (2020-04-13)

### Bug Fixes

* **api:** libraries are not sorted for restricted users ([1d58322](1d58322)), closes [#140](#140)

### Features

* **swagger:** update to OpenAPI 3 ([c9de7c8](c9de7c8))
@gotson
Copy link
Owner

gotson commented Apr 13, 2020

🎉 This issue has been resolved in version 0.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gotson @sonostrass