Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix html reporter empty sourceStore problem with browserify #304

Closed
wants to merge 1 commit into from
Closed

Fix html reporter empty sourceStore problem with browserify #304

wants to merge 1 commit into from

Conversation

johnny-mh
Copy link
Contributor

i use this istanbul module for coverage reports.

karma-browserify + browserify-istanbul is powerful but has some issue.

the issue is sourceStore to be empty like below code.

console.log(sourceStore);    // { sourceCache: {} }
// this are make writeDetailPage() -> sourceText to undefined.

so i add some validate function for check empty sourceStore object.

@mwq27
Copy link

mwq27 commented Mar 10, 2015

👍 I had this exact same problem. I added your changes and finally it's working. Thanks @everedifice

@yleviel
Copy link

yleviel commented May 7, 2015

I also tested this out and it fixed the html reporter errors for me.

@davglass
Copy link
Collaborator

Merged in 9c98c51 after a rebase with master to clean up the conflicts.

@davglass davglass closed this May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants