This repository has been archived by the owner on Nov 9, 2021. It is now read-only.
Fixed lint-theme not failing on fail and excluded node_modules. #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubarhouse
approved these changes
May 12, 2020
steveworley
approved these changes
May 12, 2020
|
I've restarted the tugboat environment and GitHub doesn't seem to realize it has passed... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a commutative PR that addresses 2 things:
lint-themenot returning a non-zero code when standards are not met. Note that CI config for SaaS has a value to always bypass lint errors, so this change will not affect SaaS builds.node_modulesto the parallel-lint and PHPCS target. This has been requested in node_modules in the custom theme directory is getting linted and produces large number of warnings #224 and added as 2 PRs: 223 and 222, which were closed with a reference to thegovcms8-scaffoldproject's PR 12. While that PR is being in waiting for a year now, existing and new SaaS projects cannot use code linting functionality in full.