-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/govim: Disabling HighlightDiagnostics sometimes doesn't work #724
Comments
@leitzler any ideas? |
@cespare if you are able to share a |
Hm, looks like it could be a result of #700, I'll submit a patch tonight. |
@myitcv Sorry, didn't do a good job recording info when it happened (initially I didn't realize it was a bug; I thought that some govim option had changed and that I needed to set a new config option or something). I'm waiting for it to happen again and then I'll grab logs and also see if I can better describe the symptoms. |
OK, now I got it to happen a bunch. I'm not sure what changed. I even got it to occur with a really small example program. Also, I discovered that the highlights aren't behaving properly (beyond being shown when disabled). My test program is a single file in a package by itself with the following text:
I put this into a file named Weirdly, after I added two more lines to make it
and saved, the red squiggle didn't go away, and no red squiggle appeared under the Here's a screenshot showing this, plus the quickfix diagnostics showing that the only issue is the show govim log
|
Thanks. Like @leitzler I think I see where the issue is. |
@leitzler thanks! Giving it a try and it seems to work so far. I can confirm tomorrow if I still haven't seen it. |
@leitzler Seems to be working great so far! I'll go ahead and close this. |
I'm on the latest master as of right now (4b70552). This may be a recent regression since I don't recall this happening until the last few days.
In my .vimrc I have
Weirdly, I occasionally get the diagnostic highlights (red underline squiggles) anyway.
Unfortunately, I don't know how to reproduce this. Sometimes I use vim for an hour before it starts happening. Once I got it to happen right after I launched vim. I don't even know if, once it starts happening, it keeps happening -- each time so far when it has happened I've closed vim right away. I'll update this issue when I figure out more.
The text was updated successfully, but these errors were encountered: