cmd/govim: support GOVIM_USE_GOPLS_FROM_PATH=true for tests #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myitcv
force-pushed
the
cmd_govim_allow_gopls_from_path_for_tests
branch
3 times, most recently
from
93f3c0c
to
b4ed07d
Compare
An unsupported environment variable for govim is
GOVIM_USE_GOPLS_FROM_PATH which, when set to true, causes govim to use
gopls from PATH as opposed to its own version pinned via go.mod.
However we do not currently support specifying GOVIM_USE_GOPLS_FROM_PATH
in tests.
This commit changes that so that using a custom/local gopls via dockexec
becomes possible by specifying two additional flags to dockexec.
Firstly, bind mounting gopls:
-v /path/to/gopls:/usr/local/bin/gopls
Secondly, turning on GOVIM_USE_GOPLS_FROM_PATH:
-e GOVIM_USE_GOPLS_FROM_PATH=true.
myitcv
force-pushed
the
cmd_govim_allow_gopls_from_path_for_tests
branch
from
b4ed07d
to
6de5a9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.