BAU: Indicate whether account deleted manually in audit message #4901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbes-gds
force-pushed
the
BAU/audit-flag-manual-delete
branch
from
2193fd5
to
6fd223b
Compare
mrwilson
reviewed
Jul 15, 2024
| if (input.isPresent()) { | ||
| ipAddress = PersistentIdHelper.extractPersistentIdFromHeaders(input.get().getHeaders()); | ||
| attachLogFieldToLogs(PERSISTENT_SESSION_ID, ipAddress); | ||
| ipAddress = IpAddressHelper.extractIpAddress(input.get()); | ||
| manualDeletion = Boolean.FALSE; |
There was a problem hiding this comment.
Is there a reason we are using boxed booleans rather than primitive e.g. true and false?
mrwilson
reviewed
Jul 15, 2024
Comment on lines
119
to
122
| var pairs = | ||
| new AuditService.MetadataPair[] { | ||
| pair("manualDeletion", manualDeletion.toString()) | ||
| }; |
There was a problem hiding this comment.
This variable can probably be inlined as line 134 takes a varargs e.g.
auditService.submitAuditEvent(DELETE_ACCOUNT, auditContext, pair("manualDeletion", manualDeletion))
|
I think this may make sense as a |
alhcomer
force-pushed
the
BAU/audit-flag-manual-delete
branch
from
991fd19
to
0824563
Compare
- Changed boxed boolean to primitive boolean. - Changed metadata pair declarations to be inline. - Deleted no longer necessary buildMetadataPairs helper method.
alhcomer
force-pushed
the
BAU/audit-flag-manual-delete
branch
from
0824563
to
cf5acff
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Indicate whether account deleted manually in audit message.
HMRC have indicated that certain fields are missing from the AUTH_DELETE_ACCOUNT audit event. Account deletion can either be triggered by users, or manually as required when we have to delete accounts. For manual deletion many of the usual fields such as session ids will be missing as there is not a user session. To make this explicit a new field has been added to the event stating whether the account was deleted manually or not.
How to review