Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom script with existing MkDocs plugin #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

galund
Copy link
Contributor

@galund galund commented Nov 21, 2023

Simplification, along with fix for #54

The plugin has some issues, but this does provide a fairly simple fix for the issues in the menu.

There's still a duplication of the site name at the top of the menu (which looks odd at some screen resolutions only!) but this is maybe good enough.

@GDS-Dominic
Copy link
Contributor

GDS-Dominic commented Nov 22, 2023

I am wary about this whilst less code could be quicker and easier to maintain I think current script provides us some useful flexibility i.e. in my current branch for audit events i've been able to do a lot more manipulation with it which has come in useful
Screenshot 2023-11-22 at 11 23 43

@galund
Copy link
Contributor Author

galund commented Nov 22, 2023

I think we can build a structure like that pretty easily... which branch, I don't mind having a play?

If we do decide we want something custom then I think it might be worth writing it into an extension rather than overwriting the nav file - and I started looking at that before realising that someone had in fact already built something that does the job.

- the plugin has some issues...
- but this does provide a fairly simple fix for #54
@galund galund marked this pull request as ready for review December 5, 2023 12:32
@galund galund requested a review from cmiddi December 5, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants