Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSValue() returns js.Null() if the object is nil #11

Merged
merged 1 commit into from
Dec 1, 2022
Merged

JSValue() returns js.Null() if the object is nil #11

merged 1 commit into from
Dec 1, 2022

Conversation

ptxmac
Copy link
Contributor

@ptxmac ptxmac commented Nov 28, 2022 •
edited
Loading

See gowebapi/webapi#20 for background information

@ptxmac ptxmac mentioned this pull request Nov 28, 2022
Open
@ptxmac
Copy link
Contributor Author

ptxmac commented Nov 30, 2022

@janpfeifer fyi

janpfeifer
janpfeifer approved these changes Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@janpfeifer janpfeifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ptxmac , this is awesome!

@janpfeifer janpfeifer merged commit 909cb6c into gowebapi:master Dec 1, 2022
@ptxmac ptxmac deleted the ptx/support_nil branch December 20, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpfeifer janpfeifer janpfeifer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptxmac @janpfeifer