Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Exclamation Marks #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove Exclamation Marks #118

wants to merge 2 commits into from

Conversation

gowerc
Copy link
Owner

@gowerc gowerc commented Jul 26, 2024

Closes #112

Copy link
Contributor

github-actions bot commented Jul 26, 2024

badge

Code Coverage Summary

Filename                Stmts    Miss  Cover    Missing
--------------------  -------  ------  -------  --------------------------
R/ascii_tables.R          105       8  92.38%   10, 148, 158, 163-166, 211
R/cast_variables.R         49       0  100.00%
R/diffdf.R                209      18  91.39%   373-390, 417
R/generate_keyname.R       10       1  90.00%   16
R/identify.R              152       8  94.74%   283-290
R/is_different.R           52       0  100.00%
R/issuerows.R              40       0  100.00%
R/issues.R                 17       1  94.12%   51
R/misc_functions.R         34       2  94.12%   9, 13
R/print.R                  20       0  100.00%
TOTAL                     688      38  94.48%

Results for commit: 219939a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jul 26, 2024

Unit Tests Summary

  1 files   13 suites   6s ⏱️
 52 tests  51 ✅ 1 💤 0 ❌
578 runs  571 ✅ 7 💤 0 ❌

Results for commit 219939a.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@kieranjmartin kieranjmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the exclamation marks from the news.md is very funny, but probably unintentional?

I would recommend saving this for 2.0. I suspect some of the printed behaviour may be encoded, so I would probably do this in a more breaking release.

@gowerc gowerc added the Blocked label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lets rid of double exclamation marks
2 participants