Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use data.table backend #125

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Use data.table backend #125

wants to merge 5 commits into from

Conversation

gowerc
Copy link
Owner

@gowerc gowerc commented Jul 29, 2024

Closes #117

@gowerc gowerc changed the title WIP - Use data.table backend Use data.table backend Aug 16, 2024
@gowerc gowerc marked this pull request as ready for review August 16, 2024 15:14
@gowerc
Copy link
Owner Author

gowerc commented Aug 16, 2024

@kieranjmartin - Added an additional test and converted to full pr

Copy link
Contributor

badge

Code Coverage Summary

Filename                Stmts    Miss  Cover    Missing
--------------------  -------  ------  -------  --------------------------
R/ascii_tables.R          114       8  92.98%   10, 154, 164, 169-172, 231
R/cast_variables.R         49       0  100.00%
R/diffdf.R                201      18  91.04%   356-373, 400
R/generate_keyname.R       10       1  90.00%   16
R/identify.R              156       8  94.87%   287-294
R/is_different.R           52       0  100.00%
R/issuerows.R              40       0  100.00%
R/issues.R                 17       1  94.12%   51
R/misc_functions.R         34       2  94.12%   9, 13
R/print.R                  20       0  100.00%
TOTAL                     693      38  94.52%

Results for commit: 208b145

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

  1 files   13 suites   7s ⏱️
 55 tests  53 ✅ 2 💤 0 ❌
589 runs  581 ✅ 8 💤 0 ❌

Results for commit 208b145.

@kieranjmartin
Copy link
Collaborator

I think this should be held off for version 2. I think we might be building legacy we might want to remove.

@gowerc gowerc added the Blocked label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert backend to use data.table
2 participants