-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/design changes #105
Conversation
Limiting the page dots if more than 7.That was not looking good on mobile
reduced the Spaces
Table column size and color
Q Title space
Column size, Border color and spaces
Added container to put space
Border color, columns size and colors
@Vpdwivedi Thanks for the effort in preparing this PR. I noticed the changes are mainly "cosmetic". Please understand that there is no single best UI style for everyone. Usually we wrap our For instance:
Maybe you would like to try something like above instead? Could be much easier, and much less hustle. Cheers. |
Thank you so much for your reply. I got your point for the cosmetic changes but apart from this there are other changes like adding a container to put spacing for Cell Label, Column Width Calculation in Matrix, hiding page number dots in case more page that looks bad on the screen etc. Can you please look into those changes? Thanks. |
There seem to be a lot of changes of various aspects. Maybe (before submitting PR containing all these changes) you could file separate issues (one for each) so that others can have a better idea what you intended to improve on? Small (and cohesive) changes are usually easier to manage and put through, once consensuses are reached. |
Agreed, will do that. |
Thanks |
No description provided.