Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch the latest version of Axon #19

Merged
merged 1 commit into from
Sep 4, 2023
Merged

fix: catch the latest version of Axon #19

merged 1 commit into from
Sep 4, 2023

Conversation

yangby-cryptape
Copy link
Contributor

Fix Axon Web3 Compatible Tests since axonweb3/axon#1396.

The error message will be "[ProtocolError] Kind: Types Error: Hex should start with 0x".

References:

  • Code#1

    String::deserialize(deserializer)
        .and_then(|s| Hex::from_str(&s).map_err(serde::de::Error::custom))
  • Code#2

    if !Self::is_prefixed(s) {
        return Err(TypesError::HexPrefix.into());
    }
  • Code#3

    pub enum TypesError {
        /* ... */
        #[display(fmt = "Hex should start with 0x")]
        HexPrefix,
        /* ... */
    }

⚠️ I don't have development environment of Web3 Compatible Tests, so I didn't do tests before I pushed this PR. 🤡

@sunchengzhu sunchengzhu merged commit a073818 into gpBlockchain:master Sep 4, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants