Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix variable naming inconsistency in MP4Box initialization #386

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

gspinoza
Copy link
Contributor

Description

updated README.md to fix a variable naming inconsistency mistake in mp4boxfile initialization. The mistake is in the code for the Segmentation example.

should be:

var mp4boxfile = MP4Box.createFile();
mp4boxfile.onReady = function(info) {
  ...
};

not:

var mp4box = MP4Box.createFile();
mp4boxfile.onReady = function(info) {
  ...
};

Changes

Renamed the variable mp4box to mp4boxfile for consistency throughout the codebase.

@cconcolato cconcolato merged commit fbc0348 into gpac:master Feb 22, 2024
3 checks passed
@cconcolato
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants