Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue installing plugin #533

Closed
mattboy9921 opened this issue Nov 10, 2021 · 11 comments
Closed

Issue installing plugin #533

mattboy9921 opened this issue Nov 10, 2021 · 11 comments
Labels
enhancement external

Comments

@mattboy9921
Copy link

Upon adding a line to install a plugin, I get this:

'cut -c3- ~/.tmux.conf | sh -s __apply_plugins "1" "true" "true" "true"' returned 1

The plugin I am trying to install is tmux-menus with the line:

set -g @plugin 'jaclu/tmux-menus'

I've tried killing the tmux server and multiple times runnning <prefix> + r to no avail. I have no other plugins installed but can confirm that trying to use set -g @plugin 'tmux-plugins/tmux-cpu' did seem to work as intended, no message pop up.
@gpakosz
Copy link
Owner

gpakosz commented Nov 11, 2021

Hey @mattboy9921 👋

What version of tmux are you using?

Does the plugin work when you use TPM without Oh my tmux?

@mattboy9921
Copy link
Author

Hi @gpakosz

I was using version 2.6 on Ubuntu Server 18.04. I just upgraded to Ubuntu Server 20.04 and am now on tmux version 3.0a. It is still giving me the same issue with the plugin.

Starting with a fresh install of tmux, I can install TPM and get tmux-menus working as normal.

@gpakosz
Copy link
Owner

gpakosz commented Nov 11, 2021

Starting with a fresh install of tmux, I can install TPM and get tmux-menus working as normal

Well it looks like it does but when I try with Ubuntu 18.04 which has tmux 2.6, then running

$ /home/vagrant/.tmux/plugins/tmux-menus/menus.tmux
tmux: unknown option -- N
usage: bind-key [-cnr] [-T key-table] key command [arguments]

Shows tmux-menus is not compatible with old versions of tmux.

I didn't try with Ubuntu 20.04 and tmux 3.0a because bind-key -N was introduced in tmux 3.1. Please reach out to the plugin author(s)

@gpakosz
Copy link
Owner

gpakosz commented Nov 11, 2021

I pushed the gh-533 branch that display which tmux plugin failed to run.

In any case, it looks like you need to use a least tmux 3.1 is you want to use that plugin

@mattboy9921
Copy link
Author

I uninstalled the package manager tmux 3.0a and installed via tarball straight from Github to get tmux 3.2a. It looks like that plugin is working. I'll switch to gh-533 to see if any other plugin I might try fails to load.

@gpakosz
Copy link
Owner

gpakosz commented Nov 11, 2021

@mattboy9921 Ok will merge soon

@gpakosz
Copy link
Owner

gpakosz commented Nov 12, 2021

@mattboy9921 Any hiccup using the gh-533 branch?

@mattboy9921
Copy link
Author

@gpakosz So right now when I do <prefix> + r, it reloads but then says "One or mroe TPM plugin(s) failed". I only have that one plugin and it seems to work (besides not centering the menu that pops up). I'm not sure how to see any more details.

@gpakosz
Copy link
Owner

gpakosz commented Nov 12, 2021

It's because onf or more tpm plugin(s) failed 🙃

You can use tmux show-messages to see latest messages. There should be a message that tells which plugin failed

@mattboy9921
Copy link
Author

This is everything it gives me:
image

@gpakosz
Copy link
Owner

gpakosz commented Nov 13, 2021

You're right I pushed a buggy error detection test 😅

This should be fixed now

tunght13488 added a commit to tunght13488/.tmux that referenced this issue Nov 17, 2021
@tunght13488
Merge remote-tracking branch 'upstream/master'
805af56 
* upstream/master: (46 commits)
  updated _username() in when the ssh client doesn't support %r in ProxyCommand
  updated _ssh_or_mosh_args()
  improved _pane_info() accuracy by excluding ssh proxy connections, tee, and only considering the first child of a process
  updated tpm integration to display a message when one or more plugin(s) fails to run, closes gpakosz#533
  made background sleep process exit immediately when exiting tmux (2)
  worked around Falcon.app agent slowing everything down (3)
  do not unset @tpm-install, @tpm-update, @tpm-clean and @plugin variables after tpm has launched, fixes gpakosz#531
  reworked pane / tty introspection (3)
  added word boundaries when replacing uptime_xxx variables (2)
  reworked pane / tty introspection (2)
  added support for arguments to custom variables defined in ~/.tmux.conf.local
  added word boundaries when replacing uptime_xxx variables
  check connectivity to github.com before installing and/or updating tpm and plugins (2)
  set default-terminal to tmux-256color when available, fixes gpakosz#205, fixes gpakosz#382, closes gpakosz#386
  made background sleep process exit immediately when exiting tmux, fixes gpakosz#509
  reworked pane / tty introspection, fixes gpakosz#403, fixes gpakosz#458
  worked around Falcon.app agent slowing everything down (2), fixes gpakosz#522
  worked around Falcon.app agent slowing everything down, fixes gpakosz#492
  fixed tpm plugins not installing on CentOS 7, fixes gpakosz#520
  updated tpm integration
  ...
R-Broadley pushed a commit to rob-broadley/.tmux that referenced this issue Feb 14, 2022
@rob-broadley
Merge remote-tracking branch 'upstream/master'
b7f4329 
* upstream/master: (22 commits)
  added support for arguments to custom variables defined in ~/.tmux.conf.local (2), fixes gpakosz#547
  added the '<prefix> + Shift + Tab' binding to move to the last session
  made tpm integration and patching more robust, fixes gpakosz#540
  made _apply_bindings() work with tmux 3.4 stock bindings, fixes gpakosz#541
  Revert "use send-keys -R to clear terminal and remove the sleep call", fixes gpakosz#538
  use send-keys -R to clear terminal and remove the sleep call
  reworked pane / tty introspection (4), fixes gpakosz#535
  updated _username() in when the ssh client doesn't support %r in ProxyCommand
  updated _ssh_or_mosh_args()
  improved _pane_info() accuracy by excluding ssh proxy connections, tee, and only considering the first child of a process
  updated tpm integration to display a message when one or more plugin(s) fails to run, closes gpakosz#533
  made background sleep process exit immediately when exiting tmux (2)
  worked around Falcon.app agent slowing everything down (3)
  do not unset @tpm-install, @tpm-update, @tpm-clean and @plugin variables after tpm has launched, fixes gpakosz#531
  reworked pane / tty introspection (3)
  added word boundaries when replacing uptime_xxx variables (2)
  reworked pane / tty introspection (2)
  added support for arguments to custom variables defined in ~/.tmux.conf.local
  added word boundaries when replacing uptime_xxx variables
  check connectivity to github.com before installing and/or updating tpm and plugins (2)
  ...
cgxxv pushed a commit to cgxxv/tmuxc that referenced this issue Mar 25, 2022
@gpakosz
updated tpm integration to display a message when one or more plugin(…
ba58650 
…s) fails to run, closes gpakosz#533
ooosssososos pushed a commit to ooosssososos/.tmux that referenced this issue Mar 1, 2023
@gpakosz @ooosssososos
updated tpm integration to display a message when one or more plugin(…
31b3015 
…s) fails to run, closes gpakosz#533
farhadkarimi pushed a commit to farhadkarimi/.tmux that referenced this issue Aug 18, 2023
@gpakosz
updated tpm integration to display a message when one or more plugin(…
6b96aa9 
…s) fails to run, closes gpakosz#533
Rafiot pushed a commit to Rafiot/.tmux that referenced this issue Jan 24, 2024
@gpakosz @Rafiot
updated tpm integration to display a message when one or more plugin(…
b98fbac 
…s) fails to run, closes gpakosz#533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement external
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gpakosz @mattboy9921