Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a view showing jq's error message for invalid filter expressions #6

Closed
wants to merge 1 commit into from

Conversation

herbygillot
Copy link
Contributor

Another one; this feature adds an error view displaying jq's error message. They're usually not that informative, but still can be of some use when putting a filter expression together.

Reverts the Escape key change so that Escape can be used for dismissing the autocomplete menu if need be.

@herbygillot
Copy link
Contributor Author

(This is a UI change, so might require a new shell recording.)

@herbygillot herbygillot changed the title Add an error view displaying the error message from jq. Add a view showing jq's error message for invalid filter expressions Apr 8, 2021
@gpanders
Copy link
Owner

gpanders commented Apr 9, 2021

Why Ctrl-Q to quit in addition to Ctrl-C?

@herbygillot
Copy link
Contributor Author

Why Ctrl-Q to quit in addition to Ctrl-C?

No particular reason. Chose it randomly after removing Escape.

In any case, I've removed it.

@herbygillot herbygillot force-pushed the error-view branch 2 times, most recently from 5237719 to 1116e85 Compare April 9, 2021 05:58
Undo using Escape to exit ijq, freeing it up to dismiss the autocomplete
menu as needed.
@gpanders
Copy link
Owner

Thanks again! Merged.

@gpanders gpanders closed this Apr 10, 2021
@herbygillot
Copy link
Contributor Author

Thanks. Can we cut a new (minor) release?

@gpanders
Copy link
Owner

Sure thing, just released v0.3.1. You'll need to update the dependencies in the port since I replaced go-homedir with xdg.

@herbygillot
Copy link
Contributor Author

Sounds good, will do. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants