Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial tests #8

Merged
merged 1 commit into from
Apr 17, 2021
Merged

Add initial tests #8

merged 1 commit into from
Apr 17, 2021

Conversation

herbygillot
Copy link
Contributor

@herbygillot herbygillot commented Apr 16, 2021

  • move history to its own file
  • add Makefile targets for running tests and viewing test coverage
  • add .gitignore entry to ignore coverage file

Tests mainly cover history bits. Current test coverage is about 20.9%.

Copy link
Owner

@gpanders gpanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these changes look really good and I'm glad to have some unit tests. I just left a couple of comments.

history.go Outdated Show resolved Hide resolved
history.go Show resolved Hide resolved
- move history to its own file
- add Makefile targets for running tests and viewing test coverage
- add .gitignore entry to ignore coverage file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants