Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build-contexts as part of schema #1068

Merged

Conversation

davideasaf
Copy link
Contributor

@davideasaf davideasaf commented Jun 20, 2024

What is the current behavior?

Behavior all works for docker buildx --build-context flag, however it wasn't reflected in the schema and at first glance I thought it wasn't supported.

What is the new behavior?

the --build-context option is now a part of the executor schema.

Does this introduce a breaking change?

  • Yes
  • No

Other information

buildx --build-context is already supported by nx-tools Inputs and mapping the inputs from the executor inputs already exists.

This change simply adds it to schemas.

@davideasaf davideasaf marked this pull request as ready for review June 20, 2024 04:08
@gperdomor gperdomor merged commit 0c02e1b into gperdomor:main Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants