__str__ for gvars with nan mean or sdev doesn't crash #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, GVar will raise an exception when attempting to print (or otherwise render to string) a GVar with a nan for either its mean or sdev. For example, any of
>>> print gv.gvar(float('nan'), float('nan'))
>>> print gv.gvar(1, float('nan'))
>>> print gv.gvar(float('nan'), 1)
will raise exceptions.
The issue is in the helper function
GVar.__str__.ndec
, specifically line 92:ans = int(ans)
which raises an exception when ans is nan.
This change defines behavior for when the mean and/or sdev are nan, such that
Versus simply printing 'nan', this output format makes it easy to differentiate between a simple float nan or a GVar nan. It can be diagnostically useful to know if one of the mean or sdev are not nan, hence the 'nan +- 1' and '1 +- nan' output formats.
All GVar tests run by 'make tests' pass. All non-GSL lsqfit tests run by 'make tests' also pass.