add workaround for lessOptions in nested addons #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // fix issue with nested addons, in which case our app.options hash is actually on app.app.options. | ||
| // n.b. this can be removed once ember-cli better supports nested addons. | ||
| // (see https://github.com/gdub22/ember-cli-less/issues/36) | ||
| if (!app.options && app.app && app.app.options) app = app.app; |
There was a problem hiding this comment.
Can you make this a block if, i.e.
if (condition) {
statement;
}
|
If you can squash your commits, that would be great. Then I'll merge it. Thanks |
|
I messed up the initial push and the PR auto-closed. It's cleaned up and should be good now. |
knownasilya
pushed a commit
that referenced
this pull request
Oct 16, 2015
add workaround for lessOptions in nested addons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added workaround to get
options.pathsworking when used in nested ember-cli addons. (See #36.)