Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test enhancement #1

Merged

Conversation

peter279k
Copy link
Contributor

Changed log

  • Add php-7.2 and php-7.3 tests during Travis CI build.
  • To be compatible with future PHPUnit versions, using the PHPUnit\Framework\TestCase class namesapce instead.
  • satooshi/php-coveralls package is deprecated and using the php-coveralls/php-coveralls instead.
  • Removing the hhvm version test because it will not be different from future PHP versions.

@coveralls
Copy link

Coverage Status

Coverage decreased (-14.2%) to 83.019% when pulling dc4f911 on open-source-contributions:test_enhancement into e054418 on gpslab:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-14.2%) to 83.019% when pulling dc4f911 on open-source-contributions:test_enhancement into e054418 on gpslab:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-14.2%) to 83.019% when pulling dc4f911 on open-source-contributions:test_enhancement into e054418 on gpslab:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-14.2%) to 83.019% when pulling dc4f911 on open-source-contributions:test_enhancement into e054418 on gpslab:master.

@coveralls
Copy link

coveralls commented Dec 30, 2019

Coverage Status

Coverage decreased (-12.3%) to 84.906% when pulling 8bc2dcc on open-source-contributions:test_enhancement into e054418 on gpslab:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-14.2%) to 83.019% when pulling dc4f911 on open-source-contributions:test_enhancement into e054418 on gpslab:master.

@peter279k
Copy link
Contributor Author

@peter-gribanov, please look at this PR.

Thanks :).

@peter-gribanov
Copy link
Member

Good job. Thanks.

@peter-gribanov peter-gribanov merged commit 1702fd5 into gpslab:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants