Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac Compilation : Add opengl lib/header paths and c++11 flags. #2

Merged
merged 2 commits into from
Apr 7, 2016
Merged

Mac Compilation : Add opengl lib/header paths and c++11 flags. #2

merged 2 commits into from
Apr 7, 2016

Conversation

ashishnegi
Copy link
Contributor

About the line-ending changes :
Every time i save the file in emacs/vim, it just auto removes the line-character.
Hope its ignorable.

@gpu
Copy link
Owner

gpu commented Apr 6, 2016

Thanks for this (and apologies that I did not yet do this on my own, I've been on a conference and could not yet have a closer look at this).

I think that it will also be necessary to set

cmake_minimum_required(VERSION 3.1.0)

because that's the version where the CXX_STANDARD property was introduced. If you added this, I'd pull it accordingly, otherwise I'll pull your current version and add the version afterwards. (BTW: I just tested it on Windows, and it works properly, also the other changes for OpenGL)

@gpu gpu mentioned this pull request Apr 6, 2016
@ashishnegi
Copy link
Contributor Author

Thanks for your work on JOCL. Community should come forward to make these simple changes. :)
I did set up the 3.1.0 minimum requirement.

@gpu gpu merged commit 44aa15e into gpu:master Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants