Just to show that differences were not so many ... #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 29, 2017 11:07
…void a compilation error \n defined a new CUDA header for a first example of compartmental model \n - added an example in Gpufit\example\KineticModel_fitExample to show the behavior of the new model
… fitted curve from gpu_data.values_. When we use the old call (16 parameters) to gpufit, everything works just as before, with the new pointer set to NULL and used as a flag to control the behavior of LMFit::get_results. If we call gpufit defining also a pointer for the 17th parameter float * output_data, we get an additional output from LMFit::get_results that works as output_data_ = gpu_data.values_.copy( n_fits*info_.n_points_, output_data_ ). The change is transparent to previous code that keeps working as espected without need of additional tuning. I also added an example of the behavior of the additional output parameter in Gpufit/examples/KineticModel_fitExample_withFittingOutput/
|
This is quite old and only related to a discussion in the issues about a very specific model and the code is conflicting with actual existing code. It's unlikely anything comes out of it and I will close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But if you still don't want to merge I am fine with that, too.
I will keep working on my fork, and the first one that realizes how to do numeric integration or convolution inside a CUDA kernel will let the other know!
All the best, and really well done!